gnodet commented on code in PR #13233:
URL: https://github.com/apache/maven/pull/13233#discussion_r4070906180
##########
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvn/MavenInvoker.java:
##########
@@ -236,6 +236,17 @@ protected void populateRequest(MavenContext context,
Lookup lookup, MavenExecuti
request.setNoSnapshotUpdates(context.options().suppressSnapshotUpdates().orElse(false));
request.setGoals(context.options().goals().orElse(List.of()));
+
request.setSkippedPhases(context.options().skippedPhases().orElse(List.of()));
+ if (context.options().skipTests().orElse(false)) {
+ List<String> phases = new ArrayList<>(request.getSkippedPhases());
+ if (!phases.contains("test")) {
+ phases.add("test");
+ }
+ if (!phases.contains("integration-test")) {
+ phases.add("integration-test");
+ }
+ request.setSkippedPhases(phases);
Review Comment:
Addressed by `e2de348d`. `CommonsCliMavenOptionsTest` covers all three
requested cases: (1) `--skip-tests` alone produces `["test",
"integration-test"]` (via `skipTestsOptionSuppressesTestPhase` IT +
`skipPhasesAndSkipTestsCanCoexist` unit test), (2) combined with
`--skip-phases` doesn't drop entries, (3) idempotency when `test` is already in
the list. Thread resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
