gnodet commented on PR #13233: URL: https://github.com/apache/maven/pull/13233#issuecomment-5772423528
Addressed the two findings from the re-review (commit e4a05137cb): - **Missing tests for concurrent path**: Added `skippedPhasesMojoIsNotAddedToPlan` and `emptySkippedPhasesDoesNotFilterMojos` to `BuildPlanExecutorTest`, covering both branches of the skip-phases filter in `BuildPlanExecutor.plan()`. - **Whitespace sensitivity bug**: `CommonsCliMavenOptions.skippedPhases()` now uses `.map(String::strip)` before collecting, so `--skip-phases test, integration-test` strips leading/trailing spaces from each token. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
