gnodet-bot commented on code in PR #399:
URL: https://github.com/apache/maven-filtering/pull/399#discussion_r4103293626
##########
src/main/java/org/apache/maven/shared/filtering/Resource.java:
##########
@@ -29,8 +29,8 @@
*/
public class Resource {
- List<String> includes;
- List<String> excludes;
+ List<String> includes = new ArrayList<>();
Review Comment:
⚠️ Fields are now eagerly initialized — good. But `setIncludes(List)` (line
46) and `setExcludes(List)` (line 54) still do raw assignment without a
null-guard, so a caller can re-nullify these fields after construction. Since
this PR removed the downstream null-checks in `DefaultMavenResourcesFiltering`,
that path is now an NPE.
This was raised in the previous review and has not been addressed yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
