gnodet commented on code in PR #399:
URL: https://github.com/apache/maven-filtering/pull/399#discussion_r4103323550
##########
src/main/java/org/apache/maven/shared/filtering/Resource.java:
##########
@@ -28,8 +28,8 @@
*/
public class Resource {
- List<String> includes;
- List<String> excludes;
+ List<String> includes = new ArrayList<>();
Review Comment:
Fixed in 1ad9efb. Added null-guards to
setIncludes/setExcludes/setNonFilteredFiles and eagerly initialized
nonFilteredFiles for consistency.
##########
src/main/java/org/apache/maven/shared/filtering/Resource.java:
##########
@@ -29,8 +29,8 @@
*/
public class Resource {
- List<String> includes;
- List<String> excludes;
+ List<String> includes = new ArrayList<>();
Review Comment:
Fixed in 1ad9efb.
##########
src/main/java/org/apache/maven/shared/filtering/Resource.java:
##########
@@ -29,8 +29,8 @@
*/
public class Resource {
- List<String> includes;
- List<String> excludes;
+ List<String> includes = new ArrayList<>();
Review Comment:
Fixed in 1ad9efb.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]