gnodet commented on PR #347: URL: https://github.com/apache/maven-clean-plugin/pull/347#issuecomment-5843655871
Thanks for the thorough review @slawekjaranowski — all six inline findings are addressed in e90cf6e. Regarding the non-inline items: **Dead code (`Cleaner(Cleaner other)`)**: Removed. Also made `Cleaner` `final` and `logger` `private` since there is no subclass anymore. **Multi-module IT**: Agreed this would be valuable — a multi-module IT with `-T` covering the shared staging directory, leftover cleanup, and differing per-module `force` would protect the session-scoped design. I'll add it in a follow-up commit. **Label**: Added `maintenance`. **`verbose` dropped / `disabled` session-wide**: Documented in the class Javadoc. The `verbose` per-file logging was tied to the old `Cleaner`-as-visitor approach; the new standalone `SimpleFileVisitor` intentionally doesn't replicate it (background deletion is not user-visible). The `disabled` session-wide behavior is intentional — if `fastDir` is broken for one module, it's broken for all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
