gnodet-bot commented on code in PR #358:
URL:
https://github.com/apache/maven-clean-plugin/pull/358#discussion_r4117423315
##########
src/main/java/org/apache/maven/plugins/clean/CleanMojo.java:
##########
@@ -205,8 +205,13 @@ public class CleanMojo implements
org.apache.maven.api.plugin.Mojo {
/**
* When fast clean is enabled,
* the location where directories to be deleted will be moved prior to
background deletion.
- * If not specified, the {@code
${maven.multiModuleProjectDirectory}/target/.clean} directory will be used.
- * If the {@code ${build.directory}} has been modified, you'll have to
adjust this property explicitly.
+ * If not specified, the {@code ${rootDirectory}/.mvn/target/.clean}
directory will be used.
+ * This directory sits inside the Maven project-local directory ({@code
.mvn/}), which is already
+ * excluded from source control and used for Maven infrastructure such as
the project-local repository.
Review Comment:
💡 **Javadoc inaccuracy:** `.mvn/` itself is **not** excluded from source
control — it contains committed files like `extensions.xml` and `maven.config`.
What's excluded is `.mvn/target/`, which is covered by the typical `target/`
pattern in `.gitignore`.
The current phrasing ("which is already excluded from source control") reads
as if `.mvn/` is gitignored, which is misleading.
```suggestion
* If not specified, the {@code ${rootDirectory}/.mvn/target/.clean}
directory will be used.
* The {@code .mvn/target/} tree is covered by the standard {@code
target/} gitignore pattern,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
