gnodet-bot commented on code in PR #358:
URL:
https://github.com/apache/maven-clean-plugin/pull/358#discussion_r4118283019
##########
src/main/java/org/apache/maven/plugins/clean/BackgroundCleaner.java:
##########
@@ -326,11 +326,11 @@ synchronized boolean fastDelete(Path baseDir, boolean
force, boolean retryOnErro
return false;
}
/*
- * The default directory is
`${maven.multiModuleProjectDirectory}/target/.clean`.
- * This is fine when cleaning a multi-project, in which case this
directory will
- * be shared by all subprojects and should not interfere with any
subproject.
- * However, when cleaning a single project, that default directory may
be inside
- * the `target` directory to delete. In such case, we need a 3 steps
process:
+ * The default directory is `${rootDirectory}/.mvn/target/.clean`,
which is outside
Review Comment:
💡 This comment still says `.mvn/target/.clean` but the actual default was
renamed to `clean` (no dot) in e13997c.
```suggestion
* The default directory is `${rootDirectory}/.mvn/target/clean`,
which is outside
```
##########
src/main/java/org/apache/maven/plugins/clean/BackgroundCleaner.java:
##########
@@ -362,7 +362,7 @@ synchronized boolean fastDelete(Path baseDir, boolean
force, boolean retryOnErro
* Create a temporary directory inside `fastDir` and all parent
directories if needed.
* The prefix is the name of parent directory, which is usually the
subproject name.
* It allows to recognize the target directory when all of them are
moved to the same
- * `${maven.multiModuleProjectDirectory}/target/.clean` directory.
+ * {@code ${rootDirectory}/.mvn/target/.clean} directory.
Review Comment:
💡 Same stale reference — `.clean` → `clean`.
```suggestion
* {@code ${rootDirectory}/.mvn/target/clean} directory.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
