desruisseaux commented on code in PR #355:
URL: 
https://github.com/apache/maven-clean-plugin/pull/355#discussion_r4122427409


##########
src/it/fast-delete-default/verify.groovy:
##########
@@ -24,4 +24,7 @@ if ( new File( basedir, "target" ).exists() )
 }
 
 File buildLog = new File(basedir, 'build.log')
-return buildLog.text.contains('mvn-background-cleaner')
+// The old thread-name check ('mvn-background-cleaner') was brittle.  Instead,

Review Comment:
   We don't need to talk about the old name. For someone reading the new code 
where the old name has disappeared, it is only noise.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to