gnodet-bot commented on code in PR #355:
URL:
https://github.com/apache/maven-clean-plugin/pull/355#discussion_r4120943734
##########
src/test/java/org/apache/maven/plugins/clean/BackgroundCleanerTest.java:
##########
@@ -346,16 +346,15 @@ void scanForLeftoversIsNoOpWhenFastDirAbsent(@TempDir
Path tempDir) throws IOExc
}
// -----------------------------------------------------------------------
- // failOnError — background path cannot structurally fail the build
+ // async path logs warnings instead of throwing
// -----------------------------------------------------------------------
/**
* Background deletion failures must be logged as warnings without
throwing.
*
- * <p>{@code failOnError} has no effect when {@code fast=true}: a
session-end listener cannot
- * structurally fail the build — Maven catches whatever a listener throws
and downgrades it to
- * a warning. This test verifies that errors are reported as warnings and
that {@code onEvent}
- * returns normally.</p>
+ * <p>When {@code failOnError=false}, the deletion is offloaded to the
background executor
+ * thread. This test verifies that errors in that path are reported as
warnings and that
+ * {@code onEvent} returns normally.</p>
Review Comment:
💡 **Stale Javadoc:** This paragraph still conditions the background
offloading on `failOnError=false`, but `failOnError` no longer has any effect
in fast mode — the deletion is *always* background. Suggested replacement:
```suggestion
* <p>In fast mode, the deletion is always offloaded to the background
executor thread.
* This test verifies that errors in that path are reported as warnings
and that
* {@code onEvent} returns normally.</p>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
