gnodet commented on code in PR #1144:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/1144#discussion_r4134779424


##########
pom.xml:
##########
@@ -192,6 +192,60 @@ under the License.
         </plugin>
       </plugins>
     </pluginManagement>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-enforcer-plugin</artifactId>
+        <executions>
+          <execution>
+            <id>enforce-java-build-version</id>
+            <goals>
+              <goal>enforce</goal>
+            </goals>
+            <configuration>
+              <rules>
+                <requireJavaVersion>
+                  <!--
+                    Building this plugin requires JDK 25+ so that the 
java.lang.classfile
+                    classes in src/main/java24/ can always be compiled (with 
release=24).
+                    The compiled plugin JAR targets JDK 17 for main sources 
and JDK 24
+                    for the classfile-backed bytecode analyzer, and runs on 
any JVM >= 17.

Review Comment:
   Fixed in 9a5c56d. CI workflow now uses `ff-jdk: '25'` and `jdk-matrix: 
'["25"]'` to match the enforcer `[25,)` requirement. Dropped Microsoft 
distribution (no JDK 25 available) and removed the now-unnecessary 
matrix-exclude.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to