gnodet commented on PR #1144: URL: https://github.com/apache/maven-compiler-plugin/pull/1144#issuecomment-5892651692
@rmannibucau Thanks for the follow-up. **ASM removal:** Commit 8aec6e4 moved in that direction — the build now requires JDK 25+ (enforcer) and `ClassfileClassAnalyzer` is always compiled. However, ASM is still kept as a runtime fallback in `selectAnalyzer()` for the edge case where the plugin JAR ends up running on JDK < 24 (which shouldn't happen with the enforcer, but belt-and-suspenders). If you'd prefer to hard-drop ASM entirely and make JDK 24+ a strict runtime requirement too, I can remove `AsmClassAnalyzer` and simplify `selectAnalyzer()` to just instantiate `ClassfileClassAnalyzer` directly. That would also let us drop the ASM dependency from this module (though it's still used by `ByteCodeTransformer` for the JDK-8318913 workaround — separate concern). Would you prefer the hard-drop approach? **Centralised state:** Agreed that having a single state file carrying both ABI fingerprints and module-level metadata would be cleaner than having two separate incremental mechanisms. The current implementation already stores everything in a single versioned binary state file (`AbiIncrementalBuild.State`), so extending it with module-level info (exports, requires, etc.) should be straightforward. I'd prefer to track that as a follow-up issue though — the current PR is already substantial, and the module integration is an additive feature. Sound good? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
