gnodet-bot commented on code in PR #1144:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1144#discussion_r4177250478
##########
pom.xml:
##########
@@ -188,10 +188,88 @@ under the License.
<excludes>
<exclude>unit/**</exclude>
</excludes>
+ <!--
+ Tests run against the exploded classes directory, not the
packaged JAR.
+ The JVM's multi-release JAR dispatch does not apply to
directories, so
+ the JDK 24+ BytecodeAnalyzer override must be placed before the
root stub
+ on the classpath. We prepend META-INF/versions/24/ via the
system property
+ so it is resolved before target/classes/ by the bootstrap class
loader.
+ -->
+
<classesDirectory>${project.build.outputDirectory}/META-INF/versions/24</classesDirectory>
+ <additionalClasspathElements>
Review Comment:
💡 **Nit (low):** The comment says "We prepend META-INF/versions/24/ via the
system property" — `<classesDirectory>` is a Surefire plugin configuration
parameter, not a system property. Minor wording inaccuracy.
```suggestion
Tests run against the exploded classes directory, not the
packaged JAR.
The JVM's multi-release JAR dispatch does not apply to
directories, so
the JDK 24+ BytecodeAnalyzer override must be placed before
the root stub
on the classpath. We set classesDirectory to
META-INF/versions/24/ and add
target/classes as an additional classpath element, so the JDK
24+ version
is resolved first.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
