desruisseaux commented on PR #1144: URL: https://github.com/apache/maven-compiler-plugin/pull/1144#issuecomment-5984123261
The [answer to feedback 1](https://github.com/apache/maven-compiler-plugin/pull/1144#pullrequestreview-5406649762) seems strange (maybe it was generated by AI)? Dependency tracking never existed before this pull request. We only had a direct, one-to-one, relationship between modified files (as detected by timestamp) and recompiled files. We could very well add dependency graph without ABI. They are two orthogonal axes: * Dependency graph replaces the _one-to-one_ relationship between modified files and recompiled files by a _one-to-many_ relationship, but the modified files can still be detected by timestamp. * ABI replaces "modified files" by "_effectively_ modified files" (from the point of view of a consumer of the API). Committing the two concepts in two steps would make the reviews easier. For example, one thing that I would like to check is whether the `.abi-incremental-state` file created by this pull request could be merged with the existing file generated by the current version based on timestamps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
