ascheman commented on PR #412: URL: https://github.com/apache/maven-filtering/pull/412#issuecomment-6064214196
> By the way action is disabled ... https://github.com/apache/maven-filtering/actions/workflows/release-drafter.yml It is intentional? @slawekjaranowski Not disabled by this PR — Release Drafter is already `disabled_manually` on the repo itself (independent of any branch or the default), so the workflow won't run from any branch regardless of its `on.push.branches` filter. That makes the branch-filter alignment I'd put in here runtime-moot, so I've reverted it: this PR now leaves `.github/workflows/release-drafter.yml` exactly as the Maven 3 line (`maven-filtering-3.x`) already has it. Same principle as the rest of the `.github/` carry-over — we only pull over content that actually takes effect from the default branch (issue/PR templates, the `stale` cron); a disabled workflow doesn't, so it stays the line's own. > Did you test how release drafter will generate drafts after change It generates nothing today (disabled), and the swap doesn't change that. If the Maven 3 line ever re-enables it, fixing the filter is a separate, line-local step for whoever turns it back on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
