ascheman opened a new pull request, #418: URL: https://github.com/apache/maven-archiver/pull/418
`master` is red: two beta-6 PRs merged without rebasing left `parseBuildOutputTimestamp` with contradictory test contracts — - #401 ([MJAR-595](https://github.com/apache/maven-jar-plugin/issues/595)) clamps sub-1980 values to `DATE_MIN` in the parser; - #410 (#366) made `isNumeric` accept a leading `-` so negative epochs no longer throw a misleading error, and asserted they come back raw. A negative epoch is before 1980, and ZIP/JAR cannot represent pre-1980 timestamps, so the coherent behaviour is: negatives parse numerically (no misleading error, per #366) and then clamp to `DATE_MIN` (per MJAR-595). The production code already does exactly this — only #410's test over-specified "raw". This moves the two negative-epoch cases from `parseOutputTimestampInstant` (exact-Instant) into `parseOutputTimestampClampsToDateMin` (asserts `DATE_MIN`), turning master green. **Test-only; no production code touched.** Verified locally: `Tests run: 115, Failures: 0`. Draft pending confirmation of the intended semantics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
