arturobernalg commented on PR #13478: URL: https://github.com/apache/maven/pull/13478#issuecomment-6153000026
Thanks for the reviews. I pushed an update (amended, still one commit) with the two inline suggestions: a test for white space inside quotes (`' '` is one argument), and the unterminated-quote warning now says the rest of the value is treated as part of the last word. On `mvn.cmd`: I did not change it, and I cannot run it on Windows. My understanding is that it does not need the same fix, because `%MAVEN_ARGS%` is expanded into the command line and the JVM launcher then parses the double quotes itself, so `"-Dmaven.repo.local=C:\path with space\repo"` should already stay one argument. Single quotes are not a Windows convention, so they are not handled there. I have not verified this, so if someone can try it on Windows, or you would still prefer a shared parser (`JvmConfigParser` or `--at-file`) for both launchers, I am happy to do that in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
