arturobernalg commented on PR #13496: URL: https://github.com/apache/maven/pull/13496#issuecomment-6166419920
Thanks for the review. On the IPv4-mapped IPv6 note: the JDK converts `[::ffff:127.0.0.1]` and `[::ffff:7f00:1]` to an `Inet4Address` (127.0.0.1), and `isLoopbackAddress()` returns `true` for it, so they are already treated as local. I checked it directly and added them to the loopback tests, together with `[::ffff:8.8.8.8]` as a mapped address that stays external, and a sentence in the Javadoc. The duplication between the two classes is on purpose, as both carry the same legacy code and a shared helper can go in a separate change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
