elharo commented on code in PR #308:
URL:
https://github.com/apache/maven-remote-resources-plugin/pull/308#discussion_r4281889782
##########
src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java:
##########
@@ -992,6 +993,25 @@ protected void processResourceBundles(ClassLoader
classLoader, VelocityContext c
}
}
+ static File resolveOutputFile(File outputDirectory, String resourceName)
Review Comment:
Does anyone use this? It should probably be removed. The test can call the
other method instead.
##########
src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java:
##########
@@ -992,6 +993,25 @@ protected void processResourceBundles(ClassLoader
classLoader, VelocityContext c
}
}
+ static File resolveOutputFile(File outputDirectory, String resourceName)
+ throws IOException, MojoExecutionException {
+ return resolveOutputFile(outputDirectory,
outputDirectory.getCanonicalFile(), resourceName);
+ }
+
+ private static File resolveOutputFile(File outputDirectory, File
canonicalOutputDirectory, String resourceName)
Review Comment:
I'm not sure we need the overload here. One method might do. But if the
overload is needed it's customary to put the additional arguments at the end of
the list instead of the middle. i.e.
```
File outputDirectory, String resourceName, File canonicalOutputDirectory
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
