efegokdemir commented on code in PR #308:
URL:
https://github.com/apache/maven-remote-resources-plugin/pull/308#discussion_r4292037095
##########
src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java:
##########
@@ -992,6 +993,25 @@ protected void processResourceBundles(ClassLoader
classLoader, VelocityContext c
}
}
+ static File resolveOutputFile(File outputDirectory, String resourceName)
+ throws IOException, MojoExecutionException {
+ return resolveOutputFile(outputDirectory,
outputDirectory.getCanonicalFile(), resourceName);
+ }
+
+ private static File resolveOutputFile(File outputDirectory, File
canonicalOutputDirectory, String resourceName)
Review Comment:
The remaining method now takes `canonicalOutputDirectory` last, as suggested.
##########
src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java:
##########
@@ -992,6 +993,25 @@ protected void processResourceBundles(ClassLoader
classLoader, VelocityContext c
}
}
+ static File resolveOutputFile(File outputDirectory, String resourceName)
Review Comment:
Removed the overload in `bd06bcc`; the test and processing path now use the
single remaining method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
