gnodet commented on PR #13539: URL: https://github.com/apache/maven/pull/13539#issuecomment-6287663245
Thanks for working on this @arturobernalg! The bug fix in `LifecycleDependencyResolver` (firing the result on failure too) is straightforward and addresses #8635 directly. However, the Maven 4 API additions (`DependencyResolutionEvent`, `DependencyResolutionEventType`, `DependencyResolutionListener`) feel too specific — if we later want to expose settings building, toolchains, or other service calls to Maven 4 listeners, we'd need to create another triplet of types each time. I've opened #13646 to discuss a generic `RequestEvent` design that reuses the existing `Request`/`Result` hierarchy and scales to any service call, while still allowing specialized listeners like `DependencyResolutionListener` with convenient typed callbacks. Could you limit this PR to just the bug fix (the `LifecycleDependencyResolver` change and its test) so we can get that merged? The Maven 4 API layer can then be designed and implemented as part of #13646. _Claude Code on behalf of Guillaume Nodet_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
