arturobernalg opened a new pull request, #13677:
URL: https://github.com/apache/maven/pull/13677

   Fixes #13655.
   
   ApiRunner.createSession(injectorConsumer, localRepo, securityMode) checked 
settings.xml's localRepository before the explicit localRepo argument, so a 
caller-supplied path was silently ignored whenever settings.xml defined one.
   
   The fix swaps the precedence: explicit argument, then settings.xml, then the 
default ~/.m2/repository, matching the CLI's own 
LookupInvoker.localRepositoryPath() order, as the issue suggests.
   
   Added two tests: one that fails on the old precedence (explicit arg must win 
over settings.xml) and one covering the existing settings.xml-wins-over-default 
case. Full maven-impl module tests, checkstyle:check and spotless:check are 
green.
   
   - [x] I hereby declare this contribution to be licensed under the Apache 
License Version 2.0, January 2004
   - [x] I hereby declare that I have filed an Apache Individual Contributor 
License Agreement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to