gnodet commented on PR #13677:
URL: https://github.com/apache/maven/pull/13677#issuecomment-6340253326

   The Windows CI failures are caused by `new LocalRepository(String)` 
internally calling `File.getCanonicalFile()`, which follows junctions/symlinks 
on Windows — on GHA Windows runners the temp directory is accessible via two 
drive letters (e.g. `C:\Users\runneradmin` and `D:\Users\RUNNER~1`), so the 
path round-tripped through settings.xml comes back on a different drive.
   
   The fix is a one-liner in `ApiRunner.java` (same class of bug fixed in 
#13650 for `multiModuleProjectDirectory`):
   
   ```diff
   -        ? new LocalRepository(settings.getLocalRepository())
   +        ? new 
LocalRepository(Path.of(settings.getLocalRepository()).toAbsolutePath())
   ```
   
   `Path.of(s).toAbsolutePath()` normalises lexically without OS path 
resolution, consistent with the explicit `localRepo` and default paths above it.
   
   I pushed this commit to `gnodet/maven` branch 
`fix/issue-13655-apirunner-localrepo-precedence` if you want to cherry-pick it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to