arturobernalg commented on issue #8987: URL: https://github.com/apache/maven/issues/8987#issuecomment-6340190243
Correction on my last comment: PR #279 is open, not merged yet (no reviews on it so far), so this isn't fixed upstream yet either. To answer directly: it's your second option. The condition in both AbstractConfigurationConverter.fromExpression() and AbstractBasicConverter.fromExpression() (same check, duplicated) is currently: if (null != value && !value.isEmpty()) That's what falls an explicitly-empty element through to default-value, same as an absent one. The fix in #279 narrows it to: if (null != value) so only a genuinely absent element (value == null) falls back to the default; an explicitly empty one (value == "") is evaluated and used as a real value from here on, same as any other configured value. This isn't a one-off patch for docClassesToTargets or MNG-6434 specifically: both converters are the shared base used by every basic-typed @Parameter (String and friends) going through the Plexus/Sisu configurator, so the fix applies at the layer both this issue and MNG-6434 bottom out in, not to one plugin's field. No Maven-side change would be needed once it lands and Maven picks up a sisu release with it - this issue and MNG-6434 would resolve together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
