gnodet-bot commented on code in PR #382:
URL:
https://github.com/apache/maven-clean-plugin/pull/382#discussion_r4386154833
##########
.github/dependabot.yml:
##########
@@ -40,6 +40,17 @@ updates:
# Mockito 5 requires Java 11; the build still runs on JDK 8
- dependency-name: "org.mockito:*"
versions: [">= 5.0.0"]
+ # Maven 3 line stays on Resolver 1.x (2.x is Maven 4)
Review Comment:
⚠️ **Still inaccurate (raised previously):** Maven 3.10.0 ships Resolver
2.0.24; Resolver 2.x is not exclusive to Maven 4. If the intent is to keep the
build against Resolver 1.x for API compatibility (because `pom.xml` explicitly
pins `maven-resolver-api` at `1.9.27`), the comment should say that rather than
citing a Maven version boundary that no longer holds.
```suggestion
# maven-resolver-api is explicitly pinned to 1.9.27 in pom.xml for
compatibility;
# keep Dependabot from proposing 2.x (Maven 3.10+ and Maven 4 both
bundle Resolver 2.x).
```
##########
.github/dependabot.yml:
##########
@@ -40,6 +40,17 @@ updates:
# Mockito 5 requires Java 11; the build still runs on JDK 8
- dependency-name: "org.mockito:*"
versions: [">= 5.0.0"]
+ # Maven 3 line stays on Resolver 1.x (2.x is Maven 4)
+ - dependency-name: "org.apache.maven.resolver:*"
+ versions: [">= 2.0.0"]
+ # ASF plugins stay on the Maven 3.9 baseline (min-prerequisite
+ # decision, dev@ 2025-11; 3.10 would pull in Resolver 2.x).
Review Comment:
⚠️ **Inconsistent with pom.xml:** The comment says *"stay on the Maven 3.9
baseline"* and *"3.10 would pull in Resolver 2.x"* — but `pom.xml` already
declares `<mavenVersion>3.10.0</mavenVersion>`. The project is already on 3.10,
not 3.9. The cap `>= 3.10.0` correctly blocks 3.11.x and 4.x, but the stated
rationale ("stay on 3.9 baseline") doesn't match.
```suggestion
# Stay on Maven 3.10.x; the Maven 4 line is covered by the
maven-clean-plugin-4.x
# target-branch block above. Scoped to the core artifacts this plugin
uses; other
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
