ascheman commented on code in PR #382:
URL:
https://github.com/apache/maven-clean-plugin/pull/382#discussion_r4452140666
##########
.github/dependabot.yml:
##########
@@ -40,6 +40,12 @@ updates:
# Mockito 5 requires Java 11; the build still runs on JDK 8
- dependency-name: "org.mockito:*"
versions: [">= 5.0.0"]
+ # Maven 3 line stays on Resolver 1.x (2.x is Maven 4)
+ - dependency-name: "org.apache.maven.resolver:*"
+ versions: [">= 2.0.0"]
Review Comment:
You're both right, thanks. Two separate things, as @slawekjaranowski points
out:
1. The comment was factually wrong (Resolver 2.x isn't Maven-4-only; 3.10.x
uses it too) — fixed.
2. This plugin is already on `<mavenVersion>3.10.0</mavenVersion>`, so I've
changed the `maven-core` / `maven-plugin-api` ignore from `>= 3.10.0` to `>=
4.0.0`. Dependabot now keeps it on the 3.10.x line (and may propose newer
3.10.x) and only blocks the jump to Maven 4.
The Resolver `>= 2.0.0` ignore stays: `maven-resolver-api` is explicitly
pinned to 1.9.27 (`provided`) in the pom, so that's a deliberate
compile-baseline choice — independent of the prerequisites question
(@slachiewicz), which, as Slawek says, is a separate topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
