kwin commented on PR #2236:
URL: https://github.com/apache/maven-resolver/pull/2236#issuecomment-6441662275
> logback.xml in src/main/resources — maven-resolver-test-http ships as a
JAR consumed at <scope>test</scope> by all transport modules. Placing
logback.xml in src/main/resources packages it in the JAR and drops it onto
every consumer's test classpath. When two logback.xml files are on the
classpath, Logback picks one arbitrarily — the consumer's own config may be
silently overridden. The logback.xml only configures console output for tests
within this module, so it belongs in src/test/resources.
This logback.xml is supposed to configure all dependent modules! Placing it
in src/test/resources would prevent this transitivity!
> Hardcoded logback-classic version — the project manages SLF4J versions via
${version.slf4j} in the parent POM's dependencyManagement. The new
logback-classic dependency should follow the same pattern: add a
<version.logback> property and a dependencyManagement entry in the parent POM,
then drop the <version> tag from maven-resolver-test-http/pom.xml.
Introducing a property for a version is only reasonable if there is more
than one dependency leveraging that version. This is not the case here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
