gnodet-bot commented on code in PR #2236:
URL: https://github.com/apache/maven-resolver/pull/2236#discussion_r4388815170
##########
maven-resolver-transport-apache/src/main/java/org/eclipse/aether/transport/apache/ApacheTransporter.java:
##########
@@ -764,6 +770,34 @@ public void writeTo(OutputStream os) throws IOException {
}
}
+ private static void logImmediateRetry(
+ HttpContext context, int executionCount, int retryCount, Throwable
exception) {
+ HttpCoreContext coreContext = HttpCoreContext.adapt(context);
+ HttpRequest request = coreContext.getRequest();
+ String method = request.getRequestLine().getMethod();
+ URI uri = URIUtils.resolve(
+ URI.create(coreContext.getTargetHost().toURI()),
+ request.getRequestLine().getUri());
+ HttpTransporter.logImmediateRetry(LOGGER, method, uri, executionCount
- 1, retryCount + 1, exception);
+ }
+
+ static void logRetry(
Review Comment:
🔧 **`logRetry` is package-private but should be `private`:** this method is
only called from `ResolverServiceUnavailableRetryStrategy` (a static nested
class of `ApacheTransporter`) and can access `private` members of the enclosing
class. `logImmediateRetry` is already `private static` — `logRetry` should
match for consistency and to prevent accidental use from outside the class
(e.g. test code).
```suggestion
private static void logRetry(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
