arturobernalg opened a new pull request, #1395:
URL: https://github.com/apache/maven-assembly-plugin/pull/1395
A module that inherits a shared assembly descriptor from its parent POM can
end up with nothing matching that descriptor, which fails the build today with
"archive cannot be empty"
(org.codehaus.plexus.archiver.exceptions.EmptyArchiveException).
Adds ignoreEmptyAssemblies (property assembly.ignoreEmptyAssemblies,
defaulting to false for backward compatibility) to AbstractAssemblyMojo. When
set, DefaultAssemblyArchiver wraps the archiver chain in a new
IgnoringEmptyArchiveArchiver that catches EmptyArchiveException and skips
producing the archive instead of failing the build.
This revisits an old request (#896 / MASSEMBLY-680) that had a couple of
abandoned patch attempts over the years. The original patch caught the failure
by matching an exception message string ("You must set at least one file.")
that plexus-archiver no longer throws - current versions raise a dedicated
EmptyArchiveException, so this catches that type instead, which is both more
precise and resilient to message changes.
Added IgnoringEmptyArchiveArchiverTest for the new archiver, plus two tests
in DefaultAssemblyArchiverTest covering the wiring through createArchiver()
with the flag on and off.
---
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](https://www.apache.org/licenses/LICENSE-2.0)
check one of the following:
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
- [x] I hereby declare that I have filed an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
