arturobernalg opened a new pull request, #1888: URL: https://github.com/apache/maven-mvnd/pull/1888
-v/--version always makes Maven print its own version and return without running a build, regardless of any other arguments on the command line, so a daemon round trip can't add anything to that answer. This is the case gnodet and ppalaga discussed in #282: mvnd currently still connects to (and may spawn) a daemon just to get the same version output back. This skips that step: once the client has printed its own version banner, it returns immediately instead of falling through to the daemon-connection code for a plain -v/--version invocation. --help isn't touched here. Doing that one client-side would mean either hardcoding Maven's CLI help text in the client or generating it from the daemon's bundled Maven/cling version at mvnd's own build time (closer to what ppalaga originally proposed and gnodet was fine with) - a bigger, separate change than this one. Added a test that exercises DefaultClient.execute() with --version and bogus daemon paths: without the fix it fails trying to resolve mvnd.home to connect to a daemon; with the fix it returns successfully without ever reaching that code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
