sharanggupta opened a new pull request, #447: URL: https://github.com/apache/maven-shared-utils/pull/447
`testIllegalIndexedType` and `testIllegalMappedType` had no `fail()` after the call, and since the JUnit 5 migration (#345) `testInappropriateEncoding` catches the `AssertionFailedError` thrown by its own `fail()`, so all three passed even when nothing was thrown. They now use `assertThrows`; with the calls changed to return normally, the old tests still pass and the new ones fail. --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [ ] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
