slachiewicz opened a new pull request, #688: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/688
The Dependencies report opened each dependency's details with an inline script and two images (`icon_info_sml.gif` from the site skin, the plugin's own `close.gif`); without JavaScript the details could not be opened at all. They are now a `<details>`/`<summary>` element, so the script, both images, `copyResources()` and `resources.txt` go. The Dependency Convergence marks are text (✔ Success, ✘ Error) instead of the skin's GIFs. The former alt texts are now visible text, so their translations lose the square brackets; the unused `graph.icon.close` key is removed. Fixes #687. Open draft #627 also changes `DependenciesRenderer` and `DependenciesReport`, for an unrelated reason; whichever merges second needs a small rebase. Verified: `mvn verify` → 33 tests passed; `mvn -P run-its verify -Dinvoker.test=full-pom,MPIR-431,dependencies-java-1.7-and-1.8` → 3 passed. `full-pom` and `DependencyConvergenceReportTest` now check the new markup. --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [x] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
