gnodet-bot commented on code in PR #13799:
URL: https://github.com/apache/maven/pull/13799#discussion_r4451164509
##########
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -622,6 +622,8 @@ void logging(CliRequest cliRequest) {
}
}
+ // Logging caches System.out, so capture the stream installed by the
terminal.
+ MessageUtils.awaitTerminalInitialization();
Review Comment:
💡 When `-l` is used, `awaitTerminalInitialization()` is already called a few
lines above (inside the `LOG_FILE` block) to ensure the log file is opened
against the correct stream. This second call is intentional — it covers the
non`-l` paths — but a short comment here would help future readers understand
why both exist rather than wondering if one is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
