goutamadwant opened a new pull request, #13799: URL: https://github.com/apache/maven/pull/13799
Fixes #13793. ## Problem Terminal installation runs asynchronously and replaces `System.out`. With forced color, disabled color, or batch mode, logging can activate first and cache the original stream. Logger output and direct plugin stdout then use different stream locks for the same destination, allowing parallel output to become corrupted. ## Change Wait for terminal installation immediately before activating logging. This preserves stream caching and the existing wait before `-l` redirection. No JLine code or dependency changes are included. Add three deterministic regression tests covering forced color, disabled color, and batch mode. They delay terminal installation and verify that logging uses the installed output stream. ## Validation - All three regression tests fail without the runtime change and pass with it. - Full reactor `mvn verify` passed: zero failures or errors; eight tests skipped. - After the final test cleanup, the focused CLI tests passed again. - A 200-module reproducer on macOS with JDK 27 corrupted output on Maven 3.10.0. All 11 patched-distribution checks preserved all 18,000 records, covering parallel output, color modes, batch mode, pipes, serial execution, log-file redirection, and compatibility with the JLine fix. - Applying [JLine #2355](https://github.com/jline/jline3/pull/2355) alone still reproduced PTY corruption in three runs, confirming that the stream-caching race needs a separate fix. Windows/Git Bash and the external Core IT suite were not tested locally. ## Checklist Following this checklist to help us incorporate your contribution quickly and easily: - [x] Your pull request should address just one issue, without pulling in other changes. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice. - [x] Run `mvn verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
