arturobernalg commented on issue #1989:
URL: 
https://github.com/apache/maven-resolver/issues/1989#issuecomment-6667370516

   Took a closer look at #2157 after the reopen. There is a real gap: 
`sendAcquireResponse()`'s catch block calls `error()` without the `if 
(!closing)` guard that protects every other log call in this class, so it can 
still fire after `run()`'s `finally` has reset the static `forkedProcess` flag 
to `false` during shutdown — and in the actual forked process, `slf4j-api` 
isn't on the classpath at all, so that path throws `NoClassDefFoundError` 
instead of falling back to stdout.
   
   Opened #2266 with a fix (wraps the SLF4J calls in a `LinkageError` fallback) 
and a test that loads the real `IpcServer` class through a classloader 
mirroring the forked process classpath to prove it — confirmed it crashes 
without the fix and falls back cleanly with it. Also ran the module's 
`-Prun-its` integration tests (which actually fork the server) to make sure 
nothing else regressed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to