sharanggupta opened a new pull request, #13845:
URL: https://github.com/apache/maven/pull/13845

   Fixes #13842.
   
   With `-B`, Maven 4 logs transfers through `Slf4jMavenTransferListener`, 
which divided by `Duration.toSeconds()`. That is 0 for any transfer shorter 
than a second, so the rate became infinite and was printed as `9223372037 
GB/s`. #1985 (MNG-8436) fixed the same division in the console listener; both 
listeners now share that calculation and print the rate with 
`FileSizeFormat.formatRate`, so batch rates get one decimal like the console 
ones (`45.0 B/s`). A second commit makes `formatRate` use `Locale.ROOT`: under 
the reporter's `de_DE` it printed `31,6 kB/s` next to `7.9 kB`.
   
   `Slf4jMavenTransferListenerTest` fails on `master` with `(7.9 kB at 
9223372037 GB/s)`. `maven-4.0.x` has the same code, so a backport of both 
commits would be welcome.
   
   ---
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](https://www.apache.org/licenses/LICENSE-2.0)
   check one of the following:
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
   - [ ] I hereby declare that I have filed an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to