gnodet commented on PR #13861: URL: https://github.com/apache/maven/pull/13861#issuecomment-6672958397
Addressed review findings: 1. **Added `awaitTerminalInitialization()` in the `LOG_FILE` branch** — the original port incorrectly claimed the wait had already run. Added the call before `System.setOut(ps)`, matching [3.10.x exactly](https://github.com/apache/maven/blob/maven-3.10.x/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L611), to prevent #12188. 2. **Added Javadoc on `MessageUtils.awaitTerminalInitialization()`** — explaining when and why to call it. 3. **Tests** — porting MavenCliLoggingTest from 3.10.x to the compat layer requires non-trivial adaptation: on master/4.0.x, the logger uses `MavenLoggerFactory`/`MavenBaseLogger` (not SLF4J Simple), stream caching is controlled by different system properties (`maven.logger.*` instead of `org.slf4j.simpleLogger.*`), and `MessageUtils.systemInstall()` creates a `LineReader` that blocks synchronously. These differences make the stream-caching assertions and latch sequencing significantly different from the 3.10.x test. This can be done as a follow-up, tracking the same approach as the 3.10.x tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
