gnodet commented on PR #13861: URL: https://github.com/apache/maven/pull/13861#issuecomment-6673825508
Updated with tests. All 3 pass locally (`Tests run: 3, Failures: 0, Errors: 0`). The forced-color test required adaptation from the 3.10.x original: on master/4.0.x, `MavenSimpleLogger.configure()` renders ANSI-coloured level labels via `JLineMessageBuilderFactory`, which calls `terminal.getType()` and therefore always awaits terminal initialisation — even on the forced-color path. The test accounts for this by using a completed dumb terminal (so `configure()` doesn't block), running `logging()` with `-color=always` (which skips the explicit `awaitTerminalInitialization()` call), then swapping `System.out` afterwards to verify the logger sticks to the stream it cached at activation time. The two non-forced-color tests use the full latch dance with a blocking `FastTerminal`, identical to the 3.10.x approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
