gnodet-bot commented on code in PR #13890:
URL: https://github.com/apache/maven/pull/13890#discussion_r4504203859


##########
compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java:
##########
@@ -721,4 +721,16 @@ void testHyphenatedZeroCanonical() {
         checkVersionsEqual("1-0-1-0", "1-0-1");
         assertEquals("1-0-1", newComparable("1-0-1-0").getCanonical());
     }
+
+    /**
+     * Regression test for <a 
href="https://issues.apache.org/jira/browse/MNG-7714";>MNG-7714</a>:

Review Comment:
   💡 **Nit:** The Javadoc references 
[MNG-7714](https://issues.apache.org/jira/browse/MNG-7714) (the original 
issue), but this test was introduced as a regression test for this PR (#13889). 
Consider referencing the GitHub issue instead (or in addition) so the 
connection is clear to future readers:
   
   ```suggestion
        * Regression test for <a 
href="https://github.com/apache/maven/issues/13889";>#13889</a> /
        * <a href="https://issues.apache.org/jira/browse/MNG-7714";>MNG-7714</a>:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to