jay23606 opened a new pull request, #13898:
URL: https://github.com/apache/maven/pull/13898

   Backport of #13890 to \`maven-4.0.x\`, as requested by the reviewer on that 
PR.
   
   ## Change
   
   \`CombinationItem.toString()\` in \`ComparableVersion\` returns 
\`stringPart.toString() + digitPart.toString()\` with no separator, so 
\`3-milestone-2\` canonicalises to \`3-milestone2\`. This PR inserts the \`-\` 
separator, the same one-line fix as #13890 on \`master\`, and adds a regression 
test.
   
   ## Tests
   
   - \`mvn -B -pl compat/maven-artifact test -Dtest=ComparableVersionTest\` 
(spotless, RAT and enforcer skipped): 35 run, 0 failures, BUILD SUCCESS with 
the fix.
   - With the fix reverted, the new test fails: \`expected: <3-milestone-2> but 
was: <3-milestone2>\`.
   - \`mvn -B -pl compat/maven-artifact test\` (whole module, spotless and RAT 
skipped): 81 run, 0 failures.
   
   Not verified: spotless and RAT checks, and \`mvn -Prun-its verify\`.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to