desruisseaux commented on code in PR #1123:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/1123#discussion_r4506534686


##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -658,23 +668,26 @@ final Charset charset() {
      * and therefore applies {@code "rebuild-on-add,rebuild-on-change"} by 
default,
      * doing a full rebuild on any change even when no processor is actually 
present.
      * Projects on Java < 23 that use no annotation processor can restore 
per-file recompilation
-     * by setting {@link #proc} to {@code "none"} (or by setting this {@code 
incrementalCompilation} property explicitly).</p>
+     * by setting {@link #proc} to {@code "none"} (or by setting this {@code 
rebuildStrategy} property explicitly).</p>
      *
      * @see #staleMillis
      * @see #fileExtensions
      * @see #showCompilationChanges
      * @see #createMissingPackageInfoClass
      * @since 4.0.0
      */
-    @Parameter(property = "maven.compiler.incrementalCompilation")
-    protected String incrementalCompilation;
+    @Parameter(property = "maven.compiler.rebuildStrategy")
+    protected String rebuildStrategy;
 
     /**
-     * Whether to enable/disable incremental compilation feature.
+     * Whether to enable/disable the change detection that decides when to 
recompile the sub-project.
+     * Despite the word "incremental", this does not yet provide the same 
reliability as the incremental

Review Comment:
   Remove "yet". There is no plan to change the behaviour of this option. It is 
deprecated and may just be removed in a future version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to