arturobernalg commented on PR #13909:
URL: https://github.com/apache/maven/pull/13909#issuecomment-6736158990

   CI caught a real conflict, converting to draft.
   
   The integration-tests jobs fail across every OS/JDK combination, all on the 
same test: MavenITmng7353CliGoalInvocationTest. That test (MNG-7353, shipped in 
3.9.0) invokes e.g. `dependency:3.1.1:list@id` with no `<execution id="id">` 
declared anywhere in its project, and asserts the goal still runs, labeled 
"(id)" in the log. That's deliberate, tested CLI syntax: an arbitrary `@id` is 
meant to work as a free-form label, not necessarily a reference to a declared 
POM execution.
   
   elharo's "error, don't fix with options" direction on #7791 predates 
MNG-7353 by a few years. As implemented, this fix can't tell "typo'd a real 
execution id" apart from "intentionally labeling an ad-hoc invocation" - both 
are just `goal@someId` with nothing declared, and MNG-7353's own tests confirm 
the second case is supposed to succeed.
   
   Converting to draft rather than pushing a narrower heuristic, since I don't 
see one that holds up against MNG-7353's own test matrix. Open to input on 
whether #7791 is still fixable without touching that behavior, or whether it's 
effectively superseded by MNG-7353's design.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to