gnodet-bot commented on PR #13909:
URL: https://github.com/apache/maven/pull/13909#issuecomment-6932265141

   The conflict with `MavenITmng7353CliGoalInvocationTest` is not a real 
semantic blocker — it's a gap in the IT project itself.
   
   Looking at the [IT project 
POM](https://github.com/apache/maven/blob/master/its/core-it-suite/src/test/resources/mng-7353-cli-goal-invocation/pom.xml),
 it declares **no `<executions>` at all**. The `@id` in tests like 
`dependency:list@id` and `dependency:3.1.1:list@id` was never intended as a 
free-form annotation — it was meant to reference a declared POM execution. The 
tests just happen to exercise the undeclared-id silent-fallback path, which is 
exactly the bug MNG-5833 reports.
   
   MNG-7353 was about adding the `prefix:version:goal` shorthand. The 
`@executionId` part of the syntax predates it (MNG-5768, 3.3.1), and its 
semantics were always "scope to a declared POM execution". There is no 
intentional use case for `goal@someArbitraryLabel` as a free-form tag.
   
   The fix in the IT tests is straightforward: either add 
`<execution><id>id</id>...</execution>` to the IT project POM (to make `@id` 
reference a real declared execution), or drop the `@id` variants that don't 
have a corresponding execution (since they add no coverage beyond what 
`dependency:list` without `@id` already tests).
   
   Either way, the fix direction is correct.
   
   <!-- reviewer: gnodet-bot -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to