arturobernalg opened a new pull request, #3590: URL: https://github.com/apache/maven-surefire/pull/3590
SmartStackTraceParser.toString()/causeToString() build the trimmed stack trace shown when trimStackTrace=true, but never looked at Throwable.getSuppressed(). The untrimmed path (writeTraceToString(), which just calls Throwable.printStackTrace()) already includes suppressed exceptions, so the two output modes disagreed - a try-with-resources close() failure, or anything relying on JUnit 5's own use of suppressed exceptions, silently lost that information only when trimStackTrace was on. Add suppressedToString(), mirroring the existing causeToString(), and call it both for the top-level throwable and for each exception in the cause chain. Fixes #3073 To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [x] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
