arturobernalg commented on PR #3590: URL: https://github.com/apache/maven-surefire/pull/3590#issuecomment-6825135513
A concrete case: a test opens a DB connection or temp resource, the test body fails an assertion, and the resource's close() *also* throws (e.g. the connection pool is exhausted, or a temp file got deleted from under it). With trimStackTrace=true today, you only see the assertion failure - you have no idea the cleanup is also broken, which can be the actual root cause of flakiness in later tests in the same run. That's exactly the scenario try-with-resources suppression was designed to preserve rather than discard, and it's what the original reporter (SUREFIRE-1029/1772) ran into. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
