gnodet-bot commented on code in PR #1273: URL: https://github.com/apache/maven-plugin-tools/pull/1273#discussion_r4578284191
########## maven-plugin-annotations/src/main/java/org/apache/maven/plugins/annotations/Parameter.java: ########## @@ -36,6 +36,9 @@ * * @author Olivier Lamy * @since 3.0 + * @see <a href="https://maven.apache.org/guides/mini/guide-configuring-plugins.html">Configuring Plug-Ins</a> + * @see <a href="https://eclipse.dev/sisu/org.eclipse.sisu.plexus/configuration.html#Collection_Objects?">Plexus Component Configurator API</a> Review Comment: 📝 **Doc fix:** The URL fragment `#Collection_Objects?` has a trailing `?` after the anchor name. This `?` is not part of a valid HTML anchor identifier and will prevent browsers from scrolling to that section. It should be `#Collection_Objects` (without the `?`). ########## maven-plugin-annotations/src/main/java/org/apache/maven/plugins/annotations/Parameter.java: ########## @@ -36,6 +36,9 @@ * * @author Olivier Lamy * @since 3.0 + * @see <a href="https://maven.apache.org/guides/mini/guide-configuring-plugins.html">Configuring Plug-Ins</a> + * @see <a href="https://eclipse.dev/sisu/org.eclipse.sisu.plexus/configuration.html#Collection_Objects?">Plexus Component Configurator API</a> + * @see <a href="https://jcp.org/en/jsr/detail?id=330">Mojo API</a> Review Comment: 📝 **Doc fix:** The link label `"Mojo API"` doesn't match the URL target. `https://jcp.org/en/jsr/detail?id=330` is the JSR 330 (Dependency Injection for Java) specification page, not the Mojo API. Consider using a label like `"JSR 330 (Dependency Injection for Java)"` to accurately describe the linked resource. ########## maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScanner.java: ########## @@ -275,6 +275,7 @@ private void analyzeClassStream( protected void populateAnnotationContent(Object content, MojoAnnotationVisitor mojoAnnotationVisitor) throws ReflectorException { + /** This only iterates over explicitly defined annotation values, not implicit default values */ Review Comment: 🔧 **Style nit:** `/** ... */` is Javadoc syntax intended for declarations (classes, methods, fields), not for inline code comments inside method bodies. Use `// ...` or `/* ... */` here instead: ```suggestion // This only iterates over explicitly defined annotation values, not implicit default values ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
