slawekjaranowski commented on code in PR #1273:
URL:
https://github.com/apache/maven-plugin-tools/pull/1273#discussion_r4589616794
##########
maven-plugin-annotations/src/main/java/org/apache/maven/plugins/annotations/Parameter.java:
##########
@@ -62,14 +65,30 @@
String property() default "";
/**
- * parameter default value, may contain <code>${...}</code> expressions
which will be interpreted at
+ * Parameter default value, may contain <code>${...}</code> expressions
which will be interpreted at
* inject time: see
- * <a
href="/ref/current/maven-core/apidocs/org/apache/maven/plugin/PluginParameterExpressionEvaluator.html">
+ * <a
href="https://maven.apache.org/ref/current/maven-core/apidocs/org/apache/maven/plugin/PluginParameterExpressionEvaluator.html">
* PluginParameterExpressionEvaluator</a>.
+ * The type conversion from String into the target type is described in <a
href="https://maven.apache.org/guides/mini/guide-configuring-plugins.html#Configuring_Parameters">Configuring
Parameters</a>.
+ * Cannot be specified together with {@link #defaultValues()}.
* @return the default value
+ * @see #defaultValues()
*/
String defaultValue() default "";
+ /**
+ * Default values concatenated with commas in the generated plugin
descriptor.
+ * Each String value has the format outlined in {@link #defaultValue()}.
+ * Note that the String itself must not contain commas as those are always
interpreted as value separation characters (with no way to escape them).
+ * Multiple values are only supported for <a
href="https://maven.apache.org/guides/mini/guide-configuring-plugins.html#mapping-collections-and-arrays">collection
or array type parameters</a>.
+ * Cannot be specified together with {@link #defaultValue()}, even if
either is explicitly empty.
+ * Descriptor generation requires maven-plugin-plugin 4.0.0-beta-4 or
later.
Review Comment:
As I see it will be put in default value in plugin descriptor .... so it
will also works in Maven 3.x without changing in Maven core - right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]