slachiewicz opened a new pull request, #334:
URL: https://github.com/apache/maven-dependency-analyzer/pull/334

   Replace AssertJ assertions with JUnit 5 so the tests no longer need a 
third-party assertion library.
   
   - Migrated all 176 `assertThat(` calls and the single `assertThatCode(` call 
across 12 test files to `org.junit.jupiter.api.Assertions`, preserving each 
check (including chained, `allSatisfy`, `map`, `extracting`, 
`first`/`singleElement` and exact-exception assertions) as separate JUnit 
statements.
   - Removed the `assertj-core` test dependency and the now-unused 
`assertj-bom` import from `pom.xml`.
   - Kept Java 8 compatibility (no `List.of`/`Map.of`/`var`) and left every 
test case intact.
   
   Tracking: apache/maven-dependency-analyzer#329
   
   Verified: 
`JAVA_HOME=/Library/Java/JavaVirtualMachines/zulu-21.jdk/Contents/Home mvn -B 
-o test` → BUILD SUCCESS, 146 tests run / 0 failures / 0 errors across 13 
classes; per-class surefire `tests=` counts identical to master (146 → 146). 
Mutation check: changing one migrated `containsOnly` assertion in 
`DependencyVisitorTest.testVisitWithDefaultSuperclass` produced exactly one 
failure, then the file was restored from a saved copy. No AssertJ references 
remain in `src/test` or `pom.xml`.
   
   Sequencing note: this branch also touches `ASMDependencyAnalyzerTest`, 
`DefaultClassAnalyzerTest` and `ClassFileVisitorUtilsTest`, which are also 
changed by open draft PR apache/maven-dependency-analyzer#331. Please merge 
#331 first and rebase this branch onto the updated `master` afterwards.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to