[
https://issues.apache.org/jira/browse/MESOS-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630891#comment-14630891
]
haosdent commented on MESOS-3023:
---------------------------------
Hi, [~klaus1982] Thank you for your patch, I also write some new review to it.
Maybe you need find a committer to shepherd this. Because a shepherd committer
could give you more advice and help you to commit it. :-)
And IMHO, if this pattern only use in this one place, do we still need
factoring out the pattern? Or waiting some other places also need use this
pattern, and generic it at that time?
> Factoring out the pattern for URL generation
> ---------------------------------------------
>
> Key: MESOS-3023
> URL: https://issues.apache.org/jira/browse/MESOS-3023
> Project: Mesos
> Issue Type: Task
> Reporter: Artem Harutyunyan
> Assignee: Klaus Ma
> Priority: Minor
> Labels: beginner, mesosphere, newbie
>
> fetcher_test.cpp uses the following code for generating URLs:
> string url = "http://"; + net::getHostname(process.self().address.ip).get() +
> ":" + stringify(process.self().address.port) + "/" + process.self().id
> it would be good to isolate that code in a function, and replace the code
> above with something like:
> string url = "http://"; + endpoint_url(process, "uri_test");
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
