[
https://issues.apache.org/jira/browse/MESOS-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631364#comment-14631364
]
Klaus Ma commented on MESOS-3023:
---------------------------------
Hi [~haosdent],
I just go through the code, I found we have process::http::URL already for url.
And we can get the url string by operator<< instead of a new function. I
updated the code diff by using process::http::URL in UT.
Anyway, your comments is very useful to me :).
Thanks
Klaus
> Factoring out the pattern for URL generation
> ---------------------------------------------
>
> Key: MESOS-3023
> URL: https://issues.apache.org/jira/browse/MESOS-3023
> Project: Mesos
> Issue Type: Task
> Reporter: Artem Harutyunyan
> Assignee: Klaus Ma
> Priority: Minor
> Labels: beginner, mesosphere, newbie
>
> fetcher_test.cpp uses the following code for generating URLs:
> string url = "http://"; + net::getHostname(process.self().address.ip).get() +
> ":" + stringify(process.self().address.port) + "/" + process.self().id
> it would be good to isolate that code in a function, and replace the code
> above with something like:
> string url = "http://"; + endpoint_url(process, "uri_test");
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
