[
https://issues.apache.org/jira/browse/MESOS-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741611#comment-14741611
]
Marco Massenzio commented on MESOS-3340:
----------------------------------------
Thanks [~mcypark] for taking this up.
I've done a first round of review.
The main question (for which I don't really have an answer) is whether we
should actually have a "priority" for flags (e.g., {{command-line; OS Env;
default value}}) and, instead of erroring out, we should just use the highest
priority value provided by the user.
In other words:
{noformat}
MESOS_IP=127.0.0.1 ./bin/mesos-master.sh --ip=192.168.1.2 ...
{noformat}
would result in {{hostname == "192.168.1.2"}} instead of an error.
What do you think, [~mcypark]?
[cc: [~vinodkone]]
> Command-line flags should take precedence over OS Env variables
> ---------------------------------------------------------------
>
> Key: MESOS-3340
> URL: https://issues.apache.org/jira/browse/MESOS-3340
> Project: Mesos
> Issue Type: Improvement
> Components: stout
> Affects Versions: 0.24.0
> Reporter: Marco Massenzio
> Assignee: Klaus Ma
> Labels: mesosphere, tech-debt
>
> Currently, it appears that re-defining a flag on the command-line that was
> already defined via a OS Env var ({{MESOS_*}}) causes the Master to fail with
> a not very helpful message.
> For example, if one has {{MESOS_QUORUM}} defined, this happens:
> {noformat}
> $ ./mesos-master --zk=zk://192.168.1.4/mesos --quorum=1
> --hostname=192.168.1.4 --ip=192.168.1.4
> Duplicate flag 'quorum' on command line
> {noformat}
> which is not very helpful.
> Ideally, we would parse the flags with a "well-known" priority (command-line
> first, environment last) - but at the very least, the error message should be
> more helpful in explaining what the issue is.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
